Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queries get lost when creating a case #1179

Closed
wrigleyDan opened this issue Jan 16, 2025 · 6 comments
Closed

Queries get lost when creating a case #1179

wrigleyDan opened this issue Jan 16, 2025 · 6 comments

Comments

@wrigleyDan
Copy link
Contributor

Describe the bug
One query gets lost when going through the case setup and adding multiple queries to the case. They apparently are in the case and show up when refreshing the page. But they are not listed initially.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https.//app.quepid.com
  2. Click on Relevancy Cases and select + Create a case
  3. Go with the Solr defaults until you're asked to add queries
  4. Add queries, for example star wars, harrison ford, and best action movie
  5. Finish the case setup
  6. See that only two queries are listed
  7. Refresh the page and all three queries are listed

Expected behavior
All queries are listed after finishing the case setup (if there are less than the maximum page size)

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

@wrigleyDan
Copy link
Contributor Author

Screen recording showing the issue. In the recording a refresh does not include the queries. Sometimes it does.

Screen.Recording.2025-01-16.at.12.11.38.mov

@epugh
Copy link
Member

epugh commented Jan 16, 2025

I thought it was this issue, which is that you load the case, and the queries sit there and never complete running, and you refresh and they do, and it's cuase we have the wrong params:

https://github.com/o19s/quepid/pull/1039/files#diff-14d388da237b7bba83e3c9fd0ebeb1b57443f12d1d101cea2764b7c598391b7d

However, what you are seeing, if you look in console is deadlocks ;-(. Which I ignored. :-(

@epugh
Copy link
Member

epugh commented Feb 10, 2025

wow! This was a legit bug. We were deadlocking in the database by writing each query seperately as a call.

I have migrated it to the bulk API for persisting a query, and have also chased down that we were storing a score mulitple times if you pick the same case mutliple times... weird angular messaging issues.

This is deployed now in quepid-staging.herokuapp.com, would you mind giving it a try and confirming my fixes?

@epugh
Copy link
Member

epugh commented Feb 10, 2025

Should have been a branch, not main.. oops.

54c5c9e
d8ab7a8
dbbc185

@wrigleyDan
Copy link
Contributor Author

Confirming that the behavior does not occur any more on quepid-staging.herokuapp.com 👍

@epugh
Copy link
Member

epugh commented Feb 11, 2025

thanks. Just fixed lint and unit test error, and pushing that out.

@epugh epugh closed this as completed Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants