Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Add Sitemap enabled field to FeedMe mapping screen #1070

Open
jamesmacwhite opened this issue Feb 23, 2022 · 9 comments
Open

[FR] Add Sitemap enabled field to FeedMe mapping screen #1070

jamesmacwhite opened this issue Feb 23, 2022 · 9 comments

Comments

@jamesmacwhite
Copy link

Describe the bug

When using a FeedMe feed, I want to map a specific field value to the Sitemap enabled value on the meta field, however this does appear to be visible in the feed mapping process. Other sitemap and other meta fields are visible. This field is enabled on the channel the data is wanting to importing to.

Am I missing anything? Not sure if this is a bug or a feature/request

Screenshots

image

Versions

  • Plugin version: 3.4.26
  • Craft version: 3.7.33
@khalwat
Copy link
Collaborator

khalwat commented Feb 23, 2022

It's a feature request, that's just not something that's available in the import currently

@khalwat khalwat added enhancement and removed bug labels Feb 23, 2022
@khalwat khalwat changed the title Sitemap enabled field not visible on FeedMe mapping screen [FR] Add Sitemap enabled field to FeedMe mapping screen Feb 23, 2022
@jamesmacwhite
Copy link
Author

Thanks for clarifying. The feature request would be to exposing this lightswitch field in the FeedMe mapping process.

@jamesmacwhite
Copy link
Author

Would you accept a PR on the Craft CMS 3 branch to provide this?

@khalwat
Copy link
Collaborator

khalwat commented Jul 29, 2022

I'd need to port it to Craft 4 too, but sure!

@jamesmacwhite
Copy link
Author

Thanks, I'll have at look at the FeedMe integration parts and see if I can submit a PR. If you are happy to port it, I don't currently use Craft CMS 4, which is why I was asking about Craft CMS 3 first.

@khalwat
Copy link
Collaborator

khalwat commented Jul 29, 2022

Shouldn't be bad to port it, I'm happy to do it.

@jamesmacwhite
Copy link
Author

jamesmacwhite commented Jul 29, 2022

Thanks. I'm looking at it now. Just because I haven't really worked with adding FeedMe mapping support to any field before.

It's my understanding that the sitemapUrls field needs to be added to this part: https://github.com/nystudio107/craft-seomatic/blob/v3/src/templates/_includes/integrations/feedme/seo-settings.twig#L246-L248.

The default option can be a lightswitch, given it's a bool field.

Do I need to modify any other PHP related area for it to be processed correctly?

@khalwat
Copy link
Collaborator

khalwat commented Jul 29, 2022

tbh I don't know much about it; @engram-design was kind enough to do the integration for me. I think most of the work goes into the Twig templates tho.

@jamesmacwhite
Copy link
Author

OK thanks, I thought it was mostly template related, but I'll look at commits from @engram-design on the previous values. I have got the mapping field to appear on my dev here, but I've been getting Call to a member function getAttributes() on null, so wondering if it's something in the template I'm not passing or if there's further processing somewhere.

I'll keep testing though. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants