Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nw-gyp auto add _HAS_ITERATOR_DEBUGGING=0 to compiler defines for debug #150

Open
WJsjtu opened this issue Jan 19, 2022 · 0 comments
Open

nw-gyp auto add _HAS_ITERATOR_DEBUGGING=0 to compiler defines for debug #150

WJsjtu opened this issue Jan 19, 2022 · 0 comments

Comments

@WJsjtu
Copy link

WJsjtu commented Jan 19, 2022 •
edited
Loading

nw-gyp auto add _HAS_ITERATOR_DEBUGGING=0 to compiler defines.

image

This prevents me from linking many external static libs with such error.
image

Is this macro really needed? This is really hard for me. I may add _HAS_ITERATOR_DEBUGGING=0 to my own lib but for external libs or lib depends on external libs I cannot do anything but compiling them fron source.

I've also tried node-gyp and found no such problem.

More info: Env Win10 x64 with VS2017 build for nw target v0.49.2
Min reproduct project here: gyp_test.zip (Just run run-gyp.bat)
@WJsjtu WJsjtu changed the title nw-gyp auto add _HAS_ITERATOR_DEBUGGING=0 to compiler defines nw-gyp auto add _HAS_ITERATOR_DEBUGGING=0 to compiler defines for debug Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@WJsjtu