Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get package info from project.assets.json if SDK-Style project #26

Open
MichelJansson opened this issue Mar 17, 2020 · 1 comment
Open

Comments

@MichelJansson
Copy link

Thanks for an essential tool!

Currently there is some issues with linking packages that does not have exact version, ie. Version="1.0.0-*" since that version string is straight "copied" as a folder.

One solution to this could be to read obj/project.assets.json that is generated by dotnet restore instead of the .csproj to get the currently restored version. This file also gives the benefit of that it also holds the path to the packages folder, removing the need to read the *.nuget.g.props

I'm willing to submit a PR for this it you think it sound like a good idea.

@felix-b
Copy link
Member

felix-b commented Mar 18, 2020

Hi @MichelJansson, thanks for giving this tool a try!
Yes, the idea sounds good, and a PR would be welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants