Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode: AV1 decoder tries to create an image with zero-initialized m_outImageCreateInfo #79

Open
lolzballs opened this issue Jun 4, 2024 · 1 comment

Comments

@lolzballs
Copy link
Contributor

I ran into an assertion here: Assertion failed: !"CreateImage Failed!", file C:\develop\vk_video_samples\vk_video_decoder\libs\VkCodecUtils\VkImageResource.cpp, line 37

The vkCreateImage call fails because the create info (which comes from NvPerFrameDecodeImageSet::m_outImageCreateInfo) is still zero-initialized at this point.
I bisected to 93c6657.

Callstack:

>	vk-video-dec-test.exe!VkImageResource::Create(const VulkanDeviceContext * vkDevCtx, const VkImageCreateInfo * pImageCreateInfo, unsigned int memoryPropertyFlags, VkSharedBaseObj<VkImageResource> & imageResource) Line 37	C++
 	vk-video-dec-test.exe!NvPerFrameDecodeResources::CreateImage(const VulkanDeviceContext * vkDevCtx, const VkImageCreateInfo * pImageCreateInfo, unsigned int requiredMemProps, unsigned int imageIndex, VkSharedBaseObj<VkImageResource> & imageArrayParent, VkSharedBaseObj<VkImageResourceView> & imageViewArrayParent, ImageType imageType) Line 915	C++
 	vk-video-dec-test.exe!NvPerFrameDecodeImageSet::GetImage(const VulkanDeviceContext * vkDevCtx, unsigned int imageIndex, VkVideoPictureResourceInfoKHR * pPictureResource, VulkanVideoFrameBuffer::PictureResourceInfo * pPictureResourceInfo, ImageType imageType) Line 333	C++
 	vk-video-dec-test.exe!VkVideoFrameBuffer::AcquireImageResourceByIndex(char referenceSlotIndex, VkVideoPictureResourceInfoKHR * pPictureResource, VulkanVideoFrameBuffer::PictureResourceInfo * pPictureResourceInfo, VkImageLayout newImageLayerLayout, ImageType imageType) Line 724	C++
 	vk-video-dec-test.exe!VkVideoDecoder::DecodePictureWithParameters(VkParserPerFrameDecodeParameters * pCurrFrameDecParams, VkParserDecodePictureInfo * pDecodePictureInfo) Line 580	C++
 	vk-video-dec-test.exe!NvVulkanDecoder::VulkanVideoParser::DecodePicture(VkParserPictureData * pd, vkPicBuffBase * __formal, VkParserDecodePictureInfo * pDecodePictureInfo) Line 2330	C++
 	vk-video-dec-test.exe!NvVulkanDecoder::VulkanVideoParser::DecodePicture(VkParserPictureData * pd) Line 791	C++
@zlatinski
Copy link
Contributor

Thank you, Ben! We'll fix this soon as part of the main integration of the AV1 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants