-
-
Notifications
You must be signed in to change notification settings - Fork 625
[TRACKING] issue followup for refactoring, rewrites and features planned. #877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This comment was marked as off-topic.
This comment was marked as off-topic.
I was gonna raise an issue about hanging, but since the code is being refactored, I would just describe my issue here briefly. It seems that nvimtree always read git info when refreshing the tree even with Nice plugin, BTW. |
Is this intended to be a in-place rewrite (i.e. users won't have to do anything, the code will be in the same repo and the plugin will be updated once the rewrite is done)? |
@yifeikong are you sure ? All git calls are protected by a config check. The slowdown might com from the full tree refresh. With the new version it should dramatically reduce the refresh time because of the reload being scoped to a folder only. @kirillbobyrev I'm not sure yet, and although i've started rewriting it, i'm a bit concerned about this rewrite taking too long. I have a 20% working version, but the main improvements i wanted to do are written already, so i might just port the code to the existing repository. I'll keep you guys informed when i can, but i've been really tired lately because of work. I hope i'll be better after some holidays :) |
Take your time. The current plugin works and does the job good enough. No need to rush anything. Thanks for your work. |
Hey just want to come by and say thank you :) Nice plugin XD and please take your time XD |
Eagerly awaiting! This plugin is already very cool, but a refactor will make it much better, thanks for the effort you are putting into this! |
Just a tip from a bug a found: don't initialize configuration-dependent values in immutable variables like in the renderer. These immutable values are set automatically when My use case for plugins is like this: I use I'm not sure if I should open an issue for this since the rewrite is a good chance for a fix and fixing it in the current code base would require a big refactoring. Also, from a programming point of view, this trend in lua plugins to think the common case is |
Awesome plugin!, If I can contribute to rewrite, reply me, I really want to help in this rewrite |
@13k i realized this issue with global vim variables, that's why i started to work on the setup a while ago.... Also the setup thing is controversial for some people, but given how to plugin managers initialize the plugins, it actually makes a lot of sense and allows for a clean interface between the plugin developers and the users. It also enables the plugin being initialized lazily. @lopi-py Any help is appreciated, i'll use this issue to track the ongoing refactoring that must be done in a week or two, i still have to maintain the issues and i have a lot of them unread, which takes quite a lot of time ^^ |
I love your plugin, so wanted to first of all say a big thanks and really appreciate your work. I hope the rewrite will come 💪 I was about to post a bug about how Again, thanks a lot for this nvim plugin - its sooo cool i really like it! 🙏 |
@kraegpoeth which buffer do you delete ? It might be because of the |
@kyazdani42 what further changes are you looking for? #1327 looks pretty good ;) |
indeed, i've forgot to update this one :) |
Last task tracked at #457 , closing. |
Uh oh!
There was an error while loading. Please reload this page.
Hi everyone !
I'm currently doing small refactoring iterations of the plugin. Here is a list of the refactoring and features/rewrite i want to achieve in the next few months. Theses lists will be completed incrementally.
removefilesystem_watchers.enable
and associated codepathsThe text was updated successfully, but these errors were encountered: