Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nil Assignment to frag causing errors in subsequent logic execution. #81

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix nil Assignment to frag causing errors in subsequent logic execution. #81

wants to merge 4 commits into from

Conversation

NGPONG
Copy link

@NGPONG NGPONG commented May 22, 2024 •
edited by weeman1337
Loading

This is a simple modification. The variable frag is occasionally set to nil, which disrupts the execution of subsequent logic, such as current_arg .. frag. When this issue occurs, a vexing error window appears. I earnestly hope this can be rectified. While this may not be the most optimal solution, there might be more effective alternatives. Regardless, I am more than willing to collaborate fully to support your efforts in resolving this matter.

closes #73

@weeman1337
Copy link
Collaborator

Thank you for your contribution @NGPONG 🤗

Do you in what case frag is nil? Can you give an example?

@NGPONG
Copy link
Author

NGPONG commented Jun 9, 2024

Hey @weeman1337 , thanks for the reply! I'm sorry I can't give you an answer right now, as you can see this commit is six months old! But I'm pretty sure it does happen, because I haven't had this error here since the last commit of this branch. Anyway, I'll switch back to the original branch and continue using it for a while to try to reproduce the problem.

Regards!

@NGPONG
Copy link
Author

NGPONG commented Jun 9, 2024 •
edited
Loading

Hey @weeman1337 , thanks for the reply! I'm sorry I can't give you an answer right now, as you can see this commit is six months old! But I'm pretty sure it does happen, because I haven't had this error here since the last commit of this branch. Anyway, I'll switch back to the original branch and continue using it for a while to try to reproduce the problem.

Regards!

@weeman1337 Here is a video that reproduces the problem. The erros is triggered when ' and " appear at the end of the prompt string.

2024-06-09.175811.mp4

@NGPONG
Copy link
Author

NGPONG commented Jul 9, 2024 •
edited
Loading

In order to fix some other issues 9222cc1, I have submitted some changes related to this PR. I apologize for that. I will revert it out when finalizing the confirmation.

@weeman1337
Copy link
Collaborator

Okay, so this PR does now more than only fix the nil issue, right? Can you clean it up to only fix the specific issue and create other PRs for the rest @NGPONG ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: prompt_parser.lua:139: attempt to concatenate local 'frag' (a nil value)
2 participants
@NGPONG @weeman1337