Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzzy matching is worse than normal telescope #163

Closed
sahinakkaya opened this issue Jan 5, 2024 · 4 comments
Closed

Fuzzy matching is worse than normal telescope #163

sahinakkaya opened this issue Jan 5, 2024 · 4 comments

Comments

@sahinakkaya
Copy link

sahinakkaya commented Jan 5, 2024

I don't know if this is expected behaviour (yes, it was. :FrecencyValidate! to fix) but when I run this extension, it shows me deleted files. And also the sorting seems to not working. See the screenshot attached:

20240105_14h10m59s_grim

As you can see from the right side of the terminal window, there is only 4 files in the current working directory. style/ directory is deleted. But it still shows up in Telescope frecency workspace=CWD window.

Also, config.js is not first item on the list even though I almost typed the whole file name.

Edit: I was able to fix showing deleted files issue by using :FrecencyValidate!. But it is still sorting files awkwardly.

@sahinakkaya sahinakkaya changed the title Shows deleted files and fuzzy matching is worse than normal telescope Fuzzy matching is worse than normal telescope Jan 5, 2024
@delphinus
Copy link
Member

You cannot use fuzzy-match for this picker. When you use it, telescope sorts the results again without frecency's scores ;( See #1 (comment)

In default, this picker always uses sorters.get_substr_matcher() (see here). How do you use fuzzy-match with this picker? I want to see your setup (init.lua).

@sahinakkaya
Copy link
Author

sahinakkaya commented Jan 6, 2024

How do you use fuzzy-match with this picker? I want to see your setup (init.lua).

I think you misunderstood me. I couldn't use fuzzy match and that was my request in the issue. But I got your point now. If I understand you correctly, sorting the result is handed of to telescope and you can't use a custom sorter for this plugin. If this is the case, there is nothing can be done here to fix it.

@sahinakkaya
Copy link
Author

And I also understand why you got me wrong. I misused the term "fuzzy matching" in the title while meaning telescope search results. Since telescope runs fuzzy-matcher on most of its operations, I called it normal telescope :D

@delphinus
Copy link
Member

Ah I see. I listened to you and thought it is good if such sorter, that uses fuzzy-matching and frecency scores, exists. I issued that to #165. I try it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants