Custom icons not working on latest versions

[rodhash]

:h neo-tree-diagnostics says we can add Diagnostic icons by adding:

    vim.fn.sign_define("DiagnosticSignError",
        {text = " ", texthl = "DiagnosticSignError"})
    vim.fn.sign_define("DiagnosticSignWarn",
        {text = " ", texthl = "DiagnosticSignWarn"})
...

However it's not working for me, I see just the normal letters. Is this a bug? Or am I missing something?

This is happening for "main" and "v3x" branches. V2 and V1 works fine.

Here my config, I'm using the default config:

  {
    "nvim-neo-tree/neo-tree.nvim",
    branch = "main",
    lazy = true,
    cmd = { "Neotree" },
    dependencies = {
      "nvim-lua/plenary.nvim",
      "nvim-web-devicons", -- not strictly required, but recommended
      "MunifTanjim/nui.nvim",
      -- "3rd/image.nvim", -- Optional image support in preview window: See `# Preview Mode` for more information
      {
        "s1n7ax/nvim-window-picker",
        version = "2.*",
        config = function()
          require("window-picker").setup({
            filter_rules = {
              include_current_win = false,
              autoselect_one = true,
              -- filter using buffer options
              bo = {
                -- if the file type is one of following, the window will be ignored
                filetype = { "neo-tree", "neo-tree-popup", "notify" },
                -- if the buffer type is one of following, the window will be ignored
                buftype = { "terminal", "quickfix" },
              },
            },
          })
        end,
      },
    },
    config = function()
      -- If you want icons for diagnostic errors, you'll need to define them somewhere:
      vim.fn.sign_define("DiagnosticSignError", { text = " ", texthl = "DiagnosticSignError" })
      vim.fn.sign_define("DiagnosticSignWarn", { text = " ", texthl = "DiagnosticSignWarn" })
      vim.fn.sign_define("DiagnosticSignInfo", { text = " ", texthl = "DiagnosticSignInfo" })
      vim.fn.sign_define("DiagnosticSignHint", { text = "󰌵", texthl = "DiagnosticSignHint" })

      require("neo-tree").setup({})
    end,
  },

My setup:
Neo-tree 206241e
Nvim v0.11.0-dev-301+g6c3f7e7e2

[danishjoseph]

Defining diagnostic signs with :sign-define or sign_define() is deprecated. Feature will be removed in Nvim 0.12
You can refer this snip.

{
  "neovim/nvim-lspconfig",
  opts = {
      diagnostics = {
        signs = {
          text = {
	      [vim.diagnostic.severity.ERROR] = " ",
	      [vim.diagnostic.severity.WARN] = " ",
	      [vim.diagnostic.severity.INFO] = " ",
	      [vim.diagnostic.severity.HINT] = "󰌵",
          },
        },
      },
  },
}

[pynappo]

readme is updated to reflect this, so closing