Skip to content

Never install @nuxt/fonts or @nuxt/icon if @nuxt/ui is selected #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
HugoRCD opened this issue May 12, 2025 · 3 comments · May be fixed by #879
Open

Never install @nuxt/fonts or @nuxt/icon if @nuxt/ui is selected #875

HugoRCD opened this issue May 12, 2025 · 3 comments · May be fixed by #879

Comments

@HugoRCD
Copy link
Member

HugoRCD commented May 12, 2025 •
edited
Loading

In the wizard for init a project, if the user ticks one of the official modules that is already installed by default by @nuxt/ui, the module should not be installed because it is not useful in the first place and in some cases it may bug the configurations applied by default by nuxt/ui.

https://github.com/nuxt/cli/blob/main/packages/nuxi/src/commands/init.ts#L270

I'll try to make a PR for this
@HugoRCD HugoRCD linked a pull request May 13, 2025 that will close this issue
Open
6 tasks
@danielroe
Copy link
Member

Rather than hard-coding, perhaps we can detect from the dependencies of any of these modules. If a module is a dependency then it can be removed from the list of modules to install.

@danielroe
Copy link
Member

danielroe commented May 13, 2025 •
edited
Loading

also, ideally if the user has installed nuxt/fonts or icon, then nuxt/ui should augment or override some of their configuration, but it shouldn't cause any bugs. (I would regard this as a bug if so, and we should solve it in nuxt/ui and/or fonts/icon).

@HugoRCD
Copy link
Member Author

HugoRCD commented May 13, 2025

Indeed it shouldn't 🤔 I just pushed a version without the hard-coding dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: skip already handled modules by @nuxt/ui HugoRCD/nuxt-cli
2 participants
@danielroe @HugoRCD