Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add basic v5 #424

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

add basic v5 #424

wants to merge 1 commit into from
+15,155 −0

Conversation

XanderD99
Copy link

@XanderD99 XanderD99 commented Sep 19, 2024 •
edited by benjamincanac
Loading

Resolves #423

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

a very basic v5 implementation. If I read their docs correctly only the returned format seems to have changed so I added that in a new v5 composable

It does needs to be tested however

@netlify Netlify
Copy link

netlify bot commented Sep 19, 2024 •
edited
Loading

✅ Deploy Preview for nuxt-strapi-module canceled.

Name Link
🔨 Latest commit 4117fa7
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-strapi-module/deploys/66ec42aebcb1d100085cb3b4

benjamincanac
benjamincanac requested changes Sep 19, 2024
View reviewed changes
Copy link
Member

@benjamincanac benjamincanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this!

  1. You can remove the unnecessary package-lock.json as we're using pnpm
  2. You don't need to split the composable for v5, you can just have a useStrapi, this was implemented like this to prevent breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamincanac benjamincanac benjamincanac requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Strapi v5 support
2 participants
@XanderD99 @benjamincanac