Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Improving the footer layout and ui #201

Open
devlohani99 opened this issue Feb 15, 2025 · 7 comments
Open

Enhancement: Improving the footer layout and ui #201

devlohani99 opened this issue Feb 15, 2025 · 7 comments

Comments

@devlohani99
Copy link

Image

improve the footer while providing both ideas and usability, i can:
Enhance Design & Readability

@aterrel
Copy link
Member

aterrel commented Feb 16, 2025

If you could please describe what the issue with the footer is, that would help us understand what you are proposing to do. I would hate for you to do a lot of work redesigning something and folks not agree that it is even a problem.

@VanshDagar27
Copy link

Hey! I’d love to work on this issue, but could you clarify what specific changes you’re looking for in the footer? Are you thinking about layout adjustments, styling updates, or adding/removing elements? Some details or references would help ensure the update aligns with what you have in mind. Let me know!

@devlohani99
Copy link
Author

devlohani99 commented Feb 17, 2025

If you could please describe what the issue with the footer is, that would help us understand what you are proposing to do. I would hate for you to do a lot of work redesigning something and folks not agree that it is even a problem.

@aterrel

->by adding a link to the NumFOCUS official webpage containing information about Diversity & Inclusion in Scientific
->improving the footer layout

@aterrel
Copy link
Member

aterrel commented Feb 18, 2025

@devlohani99 okay I'm not opposed to it so if you propose a PR, I will review it.

@devlohani99
Copy link
Author

@devlohani99 okay I'm not opposed to it so if you propose a PR, I will review it.

Alright

@devlohani99
Copy link
Author

devlohani99 commented Feb 19, 2025

@aterrel I previously created a pull request, after running the build command, I am seeing 10k changes. I only made edits in specific files, but I am unsure how to push only those changes without including unnecessary files. Could you guide me on how to properly push my actual code changes?

@MAMTA137 MAMTA137 mentioned this issue Feb 20, 2025
@aterrel
Copy link
Member

aterrel commented Feb 22, 2025

Sorry, looks like our install instructions led you astray. I'm more of a conda user so I didn't catch it. When you execute: python -m venv myenv it creates a folder myenv. That folder is where pip will install dependencies for jupyter book when you execute pip install -r requirements.txt, that's where the 5000+ files come from. The normal thing to do is use python -m venv .venv and then the .gitignore file tells git to not include .venv. In this case you need to add myenv to your .gitignore or we should just change the default instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants