Skip to content

Commit 6418a6d

Browse files
fix(ci): remove broken preprocessor guards from platform WebView files
The #ifdef Q_OS_MACOS / Q_OS_WIN guards wrapped the entire file but appeared before any Qt include, so without PCH the macros were undefined and the files were skipped — causing linker errors on CI. CMake already gates compilation via if(WIN32)/elseif(APPLE). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 9cd0441 commit 6418a6d

2 files changed

Lines changed: 0 additions & 8 deletions

File tree

src/widgets/WebViewWidget_mac.mm

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55
* SPDX-License-Identifier: GPL-3.0-or-later
66
*/
77

8-
#ifdef Q_OS_MACOS // Entire file is macOS-only
9-
108
#include "WebViewWidget.h"
119

1210
#include <QUrl>
@@ -143,5 +141,3 @@ - (void)webView:(WKWebView *)webView didFailProvisionalNavigation:(WKNavigation
143141
}
144142

145143
#include "WebViewWidget_mac.moc"
146-
147-
#endif // Q_OS_MACOS

src/widgets/WebViewWidget_win.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55
* SPDX-License-Identifier: GPL-3.0-or-later
66
*/
77

8-
#ifdef Q_OS_WIN // Entire file is Windows-only
9-
108
#include "WebViewWidget.h"
119

1210
#include <QCoreApplication>
@@ -368,5 +366,3 @@ WebViewWidget *WebViewWidget::create(const QString &appId, const QUrl &url, QWid
368366
{
369367
return new WebViewWidgetWin(appId, url, parent);
370368
}
371-
372-
#endif // Q_OS_WIN

0 commit comments

Comments
 (0)