Statically check handlers size == last enum value

Author: frmdstryr

atom/src/behaviors.h

@@ -205,6 +205,7 @@ enum Mode: uint8_t
     Property,
     ObjectMethod_Name,
     MemberMethod_Object,
+    Last // sentinel
 };
 
 }  // namespace GetState

atom/src/defaultvaluebehavior.cpp

@@ -202,20 +202,18 @@ handlers[] = {
     call_object_object_name_handler,
     object_method_handler,
     object_method_name_handler,
-    member_method_object_handler,
-    no_op_handler,
-    no_op_handler
+    member_method_object_handler
 };
 
-static_assert( sizeof(handlers) / sizeof(handler) == 16, "Must be exactly 16 handlers" );
+static_assert( sizeof(handlers) / sizeof(handler) == DefaultValue::Mode::Last, "Handler missing" );
 
 }  // namespace
 
 
 PyObject*
 Member::default_value( CAtom* atom )
 {
-    return handlers[ get_default_value_mode() & 0xf ]( this, atom );
+    return handlers[ get_default_value_mode() ]( this, atom );
 }
 
 

atom/src/delattrbehavior.cpp

@@ -192,15 +192,16 @@ handlers[] = {
     property_handler
 };
 
-static_assert( sizeof(handlers) / sizeof(handler) == 8, "Must be exactly 8 handlers" );
+static_assert( sizeof(handlers) / sizeof(handler) == DelAttr::Mode::Last, "Handler missing" );
+
 
 }  // namespace
 
 
 int
 Member::delattr( CAtom* atom )
 {
-    return handlers[ get_delattr_mode() & 0x7 ]( this, atom );
+    return handlers[ get_delattr_mode() ]( this, atom );
 }
 
 

atom/src/getattrbehavior.cpp

@@ -256,22 +256,18 @@ handlers[] = {
     call_object_object_name_handler,
     object_method_handler,
     object_method_name_handler,
-    member_method_object_handler,
-    no_op_handler,
-    no_op_handler,
-    no_op_handler,
-    no_op_handler
+    member_method_object_handler
 };
 
-static_assert( sizeof(handlers) / sizeof(handler) == 16, "Must be exactly 16 handlers" );
+static_assert( sizeof(handlers) / sizeof(handler) == GetAttr::Mode::Last, "Handler missing" );
 
 }  // namespace
 
 
 PyObject*
 Member::getattr( CAtom* atom )
 {
-    return handlers[ get_getattr_mode() & 0xf ]( this, atom );
+    return handlers[ get_getattr_mode() ]( this, atom );
 }
 
 }  // namespace atom

atom/src/getstatebehavior.cpp

@@ -124,20 +124,18 @@ handlers[] = {
     include_non_default_handler,
     property_handler,
     object_method_name_handler,
-    member_method_object_handler,
-    include_handler,
-    include_handler
+    member_method_object_handler
 };
 
-static_assert( sizeof(handlers) / sizeof(handler) == 8, "Must be exactly 8 handlers" );
+static_assert( sizeof(handlers) / sizeof(handler) == GetState::Mode::Last, "Handler missing" );
 
 }  // namespace
 
 
 PyObject*
 Member::should_getstate( CAtom* atom )
 {
-    return handlers[ get_getstate_mode() & 0x7 ]( this, atom );
+    return handlers[ get_getstate_mode() ]( this, atom );
 }
 
 }  // namespace atom

atom/src/postgetattrbehavior.cpp

@@ -93,21 +93,18 @@ handlers[] = {
     delegate_handler,
     object_method_value_handler,
     object_method_name_value_handler,
-    member_method_object_value_handler,
-    no_op_handler,
-    no_op_handler,
-    no_op_handler,
+    member_method_object_value_handler
 };
 
-static_assert( sizeof(handlers) / sizeof(handler) == 8, "Must be exactly 8 handlers" );
+static_assert( sizeof(handlers) / sizeof(handler) == PostGetAttr::Mode::Last, "Handler missing" );
 
 }  // namespace
 
 
 PyObject*
 Member::post_getattr( CAtom* atom, PyObject* value )
 {
-    return handlers[ get_post_getattr_mode() & 0x7 ]( this, atom, value );
+    return handlers[ get_post_getattr_mode() ]( this, atom, value );
 }
 
 

atom/src/postsetattrbehavior.cpp

@@ -106,21 +106,18 @@ handlers[] = {
     delegate_handler,
     object_method_old_new_handler,
     object_method_name_old_new_handler,
-    member_method_object_old_new_handler,
-    no_op_handler,
-    no_op_handler,
-    no_op_handler
+    member_method_object_old_new_handler
 };
 
-static_assert( sizeof(handlers) / sizeof(handler) == 8, "Must be exactly 8 handlers" );
+static_assert( sizeof(handlers) / sizeof(handler) == PostSetAttr::Mode::Last, "Handler missing" );
 
 }  // namespace
 
 
 int
 Member::post_setattr( CAtom* atom, PyObject* oldvalue, PyObject* newvalue )
 {
-    return handlers[ get_post_setattr_mode() & 0x7 ]( this, atom, oldvalue, newvalue );
+    return handlers[ get_post_setattr_mode() ]( this, atom, oldvalue, newvalue );
 }
 
 

atom/src/postvalidatebehavior.cpp

@@ -97,21 +97,18 @@ handlers[] = {
     delegate_handler,
     object_method_old_new_handler,
     object_method_name_old_new_handler,
-    member_method_object_old_new_handler,
-    no_op_handler,
-    no_op_handler,
-    no_op_handler
+    member_method_object_old_new_handler
 };
 
-static_assert( sizeof(handlers) / sizeof(handler) == 8, "Must be exactly 8 handlers" );
+static_assert( sizeof(handlers) / sizeof(handler) == PostValidate::Mode::Last, "Handler missing" );
 
 }  // namespace
 
 
 PyObject*
 Member::post_validate( CAtom* atom, PyObject* oldvalue, PyObject* newvalue )
 {
-    return handlers[ get_post_validate_mode() & 0x7 ]( this, atom, oldvalue, newvalue );
+    return handlers[ get_post_validate_mode() ]( this, atom, oldvalue, newvalue );
 }
 
 }  // namespace atom

atom/src/setattrbehavior.cpp

@@ -377,21 +377,18 @@ handlers[] = {
     call_object_object_name_value_handler,
     object_method_value_handler,
     object_method_name_value_handler,
-    member_method_object_value_handler,
-    no_op_handler,
-    no_op_handler,
-    no_op_handler
+    member_method_object_value_handler
 };
 
-static_assert( sizeof(handlers) / sizeof(handler) == 16, "Must be exactly 16 handlers" );
+static_assert( sizeof(handlers) / sizeof(handler) == SetAttr::Mode::Last, "Handler missing" );
 
 } // namespace
 
 
 int
 Member::setattr( CAtom* atom, PyObject* value )
 {
-    return handlers[ get_setattr_mode() & 0xf ]( this, atom, value );
+    return handlers[ get_setattr_mode() ]( this, atom, value );
 }
 
 

atom/src/validatebehavior.cpp

@@ -1000,15 +1000,14 @@ handlers[] = {
     member_method_object_old_new_handler
 };
 
+static_assert( sizeof(handlers) / sizeof(handler) == Validate::Mode::Last, "Handler missing" );
 
 }  // namespace
 
 
 PyObject*
 Member::validate( CAtom* atom, PyObject* oldvalue, PyObject* newvalue )
 {
-    if( get_validate_mode() >= sizeof( handlers ) / sizeof( handler ) )
-        return no_op_handler( this, atom, oldvalue, newvalue );  // LCOV_EXCL_LINE
     return handlers[ get_validate_mode() ]( this, atom, oldvalue, newvalue );
 }