Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

responsive frame types do not extend base types #528

Open
cainlevy opened this issue Jul 16, 2020 · 2 comments
Open

responsive frame types do not extend base types #528

cainlevy opened this issue Jul 16, 2020 · 2 comments
Labels
bug 🐛 Known and possible bugs for triage

Comments

@cainlevy
Copy link

The types available for various ResponsiveFooFrame components do not extend their base types. For example, TypeScript says there is no points prop available on <ResponsiveXYFrame />.

@cainlevy
Copy link
Author

cainlevy commented Jul 16, 2020

My attempted workaround:

type CombinedXYFrameProps = React.ComponentProps<typeof ResponsiveXYFrame> & React.ComponentProps<typeof XYFrame>;
class TypedResponsiveXYFrame extends React.Component<CombinedXYFrameProps> {
  render() {
    return <ResponsiveXYFrame {...this.props} />;
  }
}

@emeeks
Copy link
Member

emeeks commented Jul 30, 2020

Good catch.

@emeeks emeeks added the bug 🐛 Known and possible bugs for triage label Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Known and possible bugs for triage
Projects
None yet
Development

No branches or pull requests

2 participants