Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete all mention of createChannels from the README/docs #61

Open
williamstein opened this issue Dec 30, 2020 · 1 comment
Open

delete all mention of createChannels from the README/docs #61

williamstein opened this issue Dec 30, 2020 · 1 comment
Labels

Comments

@williamstein
Copy link
Contributor

You deprecated createChannels completely, but it is the first thing mentioned in the docs in the README.

CoCalc directly uses enchannel-zmq-backend via createChannels, so this was a little bit confusing, and I've been reading all the source code to figure out how to rewrite our code not using createChannels. Doing so wasn't hard, and in fact my code is a lot better just using createMainChannel. That said, you might want to rewrite the docs to reflect this (good) change.

@captainsafia
Copy link
Member

We can address this as part of upcoming doc writing work.

@willingc willingc added the docs label Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants