Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement DesignationEvent.FromStackItem() in rpcclient/rolemgmt #3729

Open
fyfyrchik opened this issue Dec 6, 2024 · 0 comments
Open

Implement DesignationEvent.FromStackItem() in rpcclient/rolemgmt #3729

fyfyrchik opened this issue Dec 6, 2024 · 0 comments
Labels
enhancement Improving existing functionality I3 Minimal impact S3 Minimally significant U3 Regular
Milestone
v0.108.0

Comments

@fyfyrchik
Copy link
Contributor

Is your feature request related to a problem? Please describe.

After #3008 we generate FromStackItem method for all event types.
In handwritten code for rolemgmt this method is missing, as it was added before that #2643.

Describe the solution you'd like

Make rpcclient/rolemgmt similar to what we get from the generator.
@fyfyrchik fyfyrchik added feature Completely new functionality I2 Regular impact labels Dec 6, 2024
@roman-khimov roman-khimov added this to the v0.108.0 milestone Dec 6, 2024
@roman-khimov roman-khimov added I3 Minimal impact U3 Regular enhancement Improving existing functionality S3 Minimally significant and removed feature Completely new functionality I2 Regular impact labels Dec 6, 2024
@AnnaShaleva AnnaShaleva modified the milestones: v0.107.2, v0.108.0 Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improving existing functionality I3 Minimal impact S3 Minimally significant U3 Regular
Projects
None yet
Milestone
v0.108.0
Development

No branches or pull requests
3 participants
@roman-khimov @AnnaShaleva @fyfyrchik