Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test should be enabled after preview3 #3705

Open
AliceInHunterland opened this issue Nov 25, 2024 · 0 comments
Open

Test should be enabled after preview3 #3705

AliceInHunterland opened this issue Nov 25, 2024 · 0 comments
Labels
enhancement Improving existing functionality I4 No visible changes S4 Routine test Unit tests U4 Nothing urgent

Comments

@AliceInHunterland
Copy link
Contributor

Enable tests after preview3 (ee3c119#r1853618989 )

			/* preview3 doesn't return any validators until there is a vote
			check: func(t *testing.T, e *executor, validators any) {
				var expected []result.Validator
				sBValidators := e.chain.GetStandByValidators()
				for _, sbValidator := range sBValidators {
					expected = append(expected, result.Validator{
						PublicKey: *sbValidator,
						Votes:     0,
						Active:    true,
					})
				}

				actual, ok := validators.(*[]result.Validator)
				require.True(t, ok)

				assert.ElementsMatch(t, expected, *actual)
			},
			*/

Possible Solution

Uncomment and check those tests (find others if any).

@AliceInHunterland AliceInHunterland added test Unit tests U4 Nothing urgent enhancement Improving existing functionality S4 Routine I4 No visible changes labels Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality I4 No visible changes S4 Routine test Unit tests U4 Nothing urgent
Projects
None yet
Development

No branches or pull requests

1 participant