Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take deployment environment into account when deciding what is affected #162

Open
MxKaras opened this issue Jun 19, 2024 · 1 comment
Open

Comments

@MxKaras
Copy link

MxKaras commented Jun 19, 2024

Our problem:

We have three environments in Github: dev, staging, and production. Our flow is that we deploy feature branches to dev, and when it is merged deploy to staging and then production. These latter two are both deploying main.

We are using this action with last-successful-event: deployment.

Right now npx nx affected -t deploy gives the following outcomes:

  • dev: incremental deploy as expected ✅
  • staging: incremental deploy as expected ✅
  • production: nothing is deployed as there is already a successful deployment to main

Proposed Solution:

Change the action to accept an optional deployment-environment that will be used when last-successful-event is deployment to differentiate between deployments to different environments.

@fvalmeida
Copy link

Hey, maintainers, do you have any recommendations on how to deal with this situation? There have been no comments so far, so I'm not sure if this is considered a problem to be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants