Skip to content

fix(Stream Deck): update elgato-stream-deck library to resolve an issue with slow discovery of HID devices #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

jstarpl
Copy link
Contributor

@jstarpl jstarpl commented Jan 21, 2025

About the Contributor

This pull request is posted on behalf of the NRK.

Type of Contribution

This is a:

Bug fix

Current Behavior

When starting or restarting Input Gateway, HID device discovery can get impractically slow. This results in the Stream Deck device not being initialized and not functioning within Input Gateway.

New Behavior

The elgato-stream-deck library is updated which seems to resolve the issue.

Testing Instructions

Other Information

The update of the dependencies required an update of the Node version bundled with this tool. It should now be using Node 22.

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@jstarpl jstarpl requested a review from a team as a code owner January 21, 2025 13:27
@jstarpl jstarpl requested a review from nytamin January 21, 2025 13:27
Copy link
Member

@nytamin nytamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good from a quick read, but something is wrong with the triggerId, from looking at the unit tests.

@jstarpl jstarpl changed the base branch from master to develop January 24, 2025 13:12
@jstarpl jstarpl merged commit b87b0d8 into develop Jan 24, 2025
4 checks passed
@jstarpl jstarpl deleted the fix/sofie-3648/streamdeck-detection-slow branch January 24, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants