Skip to content

[nrf fromlist] modules: hal_nordic: nrfx: make NRFX_SPI(M/S) selectable #3420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: collab-nrfx-4.0
Choose a base branch
from
Open

[nrf fromlist] modules: hal_nordic: nrfx: make NRFX_SPI(M/S) selectable #3420

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions modules/hal_nordic/nrfx/Kconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,11 +471,17 @@ config NRFX_SPI2
depends on $(dt_nodelabel_exists,spi2) && SOC_SERIES_NRF52X
select NRFX_SPI

DT_COMPAT_NORDIC_NRF_SPIM := nordic,nrf-spim

config NRFX_SPIM
bool
bool "SPIM driver"
depends on $(dt_has_compat,$(DT_COMPAT_NORDIC_NRF_SPIM))

DT_COMPAT_NORDIC_NRF_SPIS := nordic,nrf-spis
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't it be passed directly?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comma probably

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it is due to commas in compat name, it is the recommended way https://github.com/zephyrproject-rtos/zephyr/blob/a8bf08bf4e2f43ab915ae35b0a4e7418f7f978a8/scripts/dts/gen_driver_kconfig_dts.py#L25-L29

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, an alternative to dt_has_compat would be dt_compat_enabled. We allow using NRFX driver if the HW is there (indicated by presence of node with compat) but IMO the node does not have to be enabled

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am looking at the definitions of HAS_HW_NRF and I see they use DT_COMPAT_NORDIC_NRF_ without it being defined (probably because of what you sent). Maybe those symbols do not need to be defined?
I will approve anyway; I do not want to block it, but I have a feeling someone might comment on this when we try to merge the collab into main.


config NRFX_SPIS
bool
bool "SPIS driver"
depends on $(dt_has_compat,$(DT_COMPAT_NORDIC_NRF_SPIS))

config NRFX_SYSTICK
bool "SYSTICK driver"
Expand Down
Loading