drivers: flash: RRAM nonblocking writes #507
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog-entry-required
michalek-no
requested review from
fundakol,
kszromek-nordic,
nvlsianpu and
robertstypa
|
You can find the documentation preview for this PR here. |
michalek-no
force-pushed
the
rrw
branch
2 times, most recently
from
77f7e91 to
4c99554
Compare
removes while loop in driver. Signed-off-by: Mateusz Michalek <[email protected]>
| uint32_t pm = __get_PRIMASK(); | ||
|
|
||
| __disable_irq(); | ||
| if (write_busy) { |
Contributor
There was a problem hiding this comment.
Wouldn't it be enough to use an atomic here instead of enabling/disabling the IRQs? By setting write_busy before calling sd_flash_write, the write event should not occur before it is set.
Also, I don't see where write_busy is set to true(?).
Comment on lines
+69
to
+73
| if (evt_id == NRF_EVT_FLASH_OPERATION_SUCCESS) { | ||
| #if defined(CONFIG_SOC_FLASH_NRF_RRAM_BM) | ||
| rrw_done(); | ||
| #endif | ||
| } |
Contributor
There was a problem hiding this comment.
Any reason this cannot be an HIGHESTprio NRF_SDH_SOC_OBSERVER in soc_flash_nrf_rram.c?
Contributor
|
If we change the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes while loop in driver.