Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use --uppercase=false (or any other boolean options) #82

Open
mitranim opened this issue Feb 7, 2025 · 1 comment · May be fixed by #83
Open

Unable to use --uppercase=false (or any other boolean options) #82

mitranim opened this issue Feb 7, 2025 · 1 comment · May be fixed by #83

Comments

@mitranim
Copy link

mitranim commented Feb 7, 2025

The readme states that --uppercase is boolean and true by default. When providing --uppercase=false, I get the following error:

error: unexpected value 'false' for '--uppercase' found; no more were expected

Get similar errors for other boolean options. They all seem broken.

@mitranim mitranim changed the title Unable to use --uppercase=false Unable to use --uppercase=false (or any other boolean options) Feb 7, 2025
@mitranim
Copy link
Author

mitranim commented Feb 7, 2025

By the way, the commit aa29cb8 needlessly complicates the option. It seems cleaner to revert it to bool and supply default_value = "true" (tested, works when no CLI argument is provided). Although I think lowercase is the better default.

@mitranim mitranim linked a pull request Feb 7, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant