Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

Should node-gyp be dependency of npm-lifecycle? #4

Closed
zkochan opened this issue Sep 28, 2017 · 2 comments
Closed

Should node-gyp be dependency of npm-lifecycle? #4

zkochan opened this issue Sep 28, 2017 · 2 comments

Comments

@zkochan
Copy link
Contributor

zkochan commented Sep 28, 2017

Currently npm-lifecycle relies on the node-gyp-bin folder of npm (https://github.com/npm/lifecycle/blob/latest/index.js#L94). This makes npm-lifecycle not too usable outside of npm itself.

I think node-gyp-bin should be moved to npm-lifecycle and node-gyp should be in dependencies of npm-lifecycle.

@zkochan zkochan changed the title Should node-gyp be dependency of npm-lifecycle Should node-gyp be dependency of npm-lifecycle? Sep 28, 2017
@zkochan
Copy link
Contributor Author

zkochan commented Sep 28, 2017

Seems like the bins in node-gyp-bin should know the locations of node-gyp though, which is problematic with flat node_modules. Alternatively, maybe npm-lifecycle has to have an option to get a custom node-gyp path location.

zkochan referenced this issue in pnpm/npm-lifecycle Sep 28, 2017
@iarna
Copy link
Contributor

iarna commented Oct 14, 2017

I can see no reason that npm-lifecycle shouldn't be the thing bundling node-gyp.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants