Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error checking to various parts #15

Open
4 tasks
nopjmp opened this issue May 15, 2018 · 2 comments
Open
4 tasks

Add error checking to various parts #15

nopjmp opened this issue May 15, 2018 · 2 comments

Comments

@nopjmp
Copy link
Owner

nopjmp commented May 15, 2018

To prevent human errors and throwing back sometimes obscure cURL error messages, we should check the parameters to make sure they are valid.

  • URL check with filter api
  • Message length checks
  • Embed validation
  • Find more places for validation
@Zorono
Copy link

Zorono commented May 19, 2018

@nopjmp feel free to check my fork of your rep https://github.com/JohnMagdy/discord-communicator (the project is temporary paused)

@nopjmp
Copy link
Owner Author

nopjmp commented May 19, 2018

It's a little difficult to parse out change changes since you keep deleting and uploading through GitHub instead of using git locally when you make changes.

Quite a few additions I see as anti-features in the aspect of static strings of what color is what. It will also be hard for you to merge my code base back into your's if I do update.

Thanks for mentioning your repository though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants