Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibreOffice app identification is not great #459

Open
1 task done
kressb-gitlab opened this issue Mar 2, 2025 · 1 comment
Open
1 task done

LibreOffice app identification is not great #459

kressb-gitlab opened this issue Mar 2, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@kressb-gitlab
Copy link

Is there an existing issue for this?

  • I searched the existing issues and did not find anything similar.

Current Behavior

LibreOffice flatpak running on my system is identified as "LibreOffice XLST based filters", not the best name. It's actually LibreOffice Calc. Looking at the code it appears to be collapsing the Vec of applications into a single map of appid to App. The problem is all eight (?) of the LibreOffice desktop files have the same app id. So the way the code does this, the desktop file used is essentially random, happens to be the last lexically, but not sure if that's reliable. This issue is going to exist for any setup that has multiple desktop files for the same app id.

Expected Behavior

Not sure what the right way to fix this is but perhaps giving some precedence to the desktop file named after the actual appid (which is the one called just "LibreOffice") would help. Figuring out the which LibreOffice app it is is probably to specific to this app, but listing the generic app would be better than the one that the hash happens to produce.

Mission Center does display this as just "LibreOffice" for what that is worth.

Steps to Reproduce

No response

Debug Logs

Expand logs
REPLACE THIS SENTENCE WITH THE TERMINAL OUTPUT OF THE AFOREMENTIONED COMMAND.

Environment

Anything Else?

No response

@kressb-gitlab kressb-gitlab added the bug Something isn't working label Mar 2, 2025
@nokyan
Copy link
Owner

nokyan commented Mar 5, 2025

Hi, thanks for the issue.
LibreOffice detection has been in a pain in the rear for a while now. Since Mission Center has exported their application detection into its own crate, I'm looking into using that instead of my own app detection code in the somewhat near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants