Skip to content

Commit 91c4846

Browse files
authored
Merge pull request #428 from nschonni/clean-node8
Update update.sh for Node 8+ change of Alpine version
2 parents 17a8343 + 54ebc3d commit 91c4846

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

update.sh

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,10 @@ function update_node_version {
2323
rm "$dockerfile.bak"
2424
sed -E -i.bak 's/^(ENV YARN_VERSION ).*/\1'"$yarnVersion"'/' "$dockerfile"
2525
rm "$dockerfile.bak"
26+
if [[ "${version/.*/}" -ge 8 ]]; then
27+
sed -E -i.bak 's/FROM alpine:3.4/FROM alpine:3.6/' "$dockerfile"
28+
rm "$dockerfile.bak"
29+
fi
2630
)
2731
}
2832

@@ -40,7 +44,7 @@ for version in "${versions[@]}"; do
4044
for variant in $variants; do
4145
# Skip non-docker directories
4246
[ -f "$version/$variant/Dockerfile" ] || continue
43-
47+
4448
template="Dockerfile-$variant.template"
4549
dockerfile="$version/$variant/Dockerfile"
4650

0 commit comments

Comments
 (0)