Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: use template for issue #3

Open
mhdawson opened this issue Nov 2, 2017 · 7 comments
Open

TODO: use template for issue #3

mhdawson opened this issue Nov 2, 2017 · 7 comments

Comments

@mhdawson
Copy link
Member

mhdawson commented Nov 2, 2017

Currently uses make-node-meeting for content of github issue.

Would be better if a template was used. Extract the part which creates the time from make-node-meeting and use templates instead for the issue generation.

@bnb
Copy link
Contributor

bnb commented Nov 8, 2017

I would love to help create the structure of a template based on some of the formatting/content structure issues I have with make-node-meeting. Would you be interested in this?

@mhdawson
Copy link
Member Author

@bnb sure. If I understand correctly you'd like to propose a standard template that each WG could start with ?

@priyank-p
Copy link
Contributor

@mhdawson just want to ask what do i have to do?

(I have no idea.)

@mhdawson
Copy link
Member Author

@cPhost the steps I'd suggest are:

  1. Figure out how to extract the part which generates the time section from node_modules/make-node-meeting/make-node-meeting.sh That is all we really need from that script at this point.
  2. Duplicate that logic in create-node-meeting-artifacts which creates the template for the google doc, except have it read the template information from meeting_issue_base_XXX where XXX is TSC, Release etc. as specified when the script is launched
  3. Update create-node-meeting-artifacts to populate the issue with the output from 2) instead of make-node-meeting.sh

Does that make sense ?

@priyank-p
Copy link
Contributor

I will start working on it. Thanks.

@priyank-p
Copy link
Contributor

priyank-p commented Nov 22, 2017

@mhdawson i can get the date with out make-node-meeting using a bash script but currently dont know what to change in step 2^.

@mhdawson
Copy link
Member Author

@cPhost we can either call make-node-meeting and extract the date info, or look at how it gets it and duplicate it in Node.js so we can put it directly into create-node-meeting-artifacts and not have to call make-node-meeting at all.

I'd prefer removing the call to create-node-meeting-artifacts if that is possible.

In terms of what to change in step 2, the current code calls make-node-meeting and uses the string returned as the content for the issue. What we want to do instead is to read a new template from a file,
substitute the appropriate values into it (like the date info). We already use a template to get the the string used to create the google doc and we should be able to duplicate some of that code and update to read in from a different template file).

If this does not make sense from what you can see in the code then we should try to schedule a time to do a hangout and walk through it together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants