Skip to content

List available subsystems #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lholmquist opened this issue Jul 10, 2019 · 1 comment · Fixed by #67
Closed

List available subsystems #66

lholmquist opened this issue Jul 10, 2019 · 1 comment · Fixed by #67

Comments

@lholmquist
Copy link
Contributor

Sort of related to #58, but this command would list the available subsystems to choose from.

When i was creating a Node core PR, i got a validation error because i used a subsystem that wasn't defined, then i had to go into the code of this repo to find the available ones.

Having the ability to list those values from the core-validate-commit tool would have been nice.

I not sure how the command might look though. maybe something like

core-validate-commit --list subsystem or something

I'm more than happy to work on getting a PR ready for discussion
@richardlau
Copy link
Member

I'm more than happy to work on getting a PR ready for discussion

Go for it 😁.

lholmquist added a commit to lholmquist/core-validate-commit that referenced this issue Jul 11, 2019
@lholmquist
bin: add a flag to list the subsystems
31df2dd 
This commit adds the flag --list-subsystems to list all the subsystems that are available for use.

fixes nodejs#66
@lholmquist lholmquist mentioned this issue Jul 11, 2019
Merged
richardlau pushed a commit that referenced this issue Jul 15, 2019
@lholmquist @richardlau
bin: add a flag to list the subsystems (#67)
30145f9 
Adds the flag --list-subsystems to list all the subsystems that are available for use.

Fixes: #66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bin: add a flag to list the subsystems lholmquist/core-validate-commit
2 participants
@lholmquist @richardlau