Update Moderation Policy to better handle cases of deleted issues #749
+5
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gireeshpunathil
approved these changes
Nov 8, 2022
Trott
reviewed
Nov 8, 2022
| * A new issue within the private nodejs/moderation repository. | ||
| provided, it must be provided in a new issue within the private | ||
| [nodejs/moderation][] repository. The reason for this is that we want to keep | ||
| a trace of the Moderation action even if the issue or pull request is deleted |
There was a problem hiding this comment.
Pull requests cannot be deleted.
Is this relevant for any moderation action or is this really just for blocking?
There was a problem hiding this comment.
I'm not sure, I think only blocking makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not rare to document the moderation action as a comment in the same thread, this can be a problem when the issue gets deleted and there's no trace left of the explanation. I suggest to always create an issue in the moderation repo, that way all moderation action are centralized, and not at risk of being victim of collateral damage when spam content is deleted.
//cc @nodejs/moderation @nodejs/tsc