You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We recently migrated from the builtin dockerTools to nix2container (TraceMachina/nativelink@1a43ef9). Just now did I notice that our annotations are no longer visible in the github actions tab.
It looks like the config.Labels section behaves slightly differently between the two.
dockerTools adds the labels to the manifest, visible with docker manifest inspect someimage, while nix2container adds it to the Config section in the output of docker image inspect someimage.
Annotations in the OCI spec may be used to add additional information to an image: https://github.com/opencontainers/image-spec/blob/main/annotations.md
We recently migrated from the builtin
dockerTools
tonix2container
(TraceMachina/nativelink@1a43ef9). Just now did I notice that our annotations are no longer visible in the github actions tab.Before migration:
https://github.com/TraceMachina/nativelink/pkgs/container/nativelink/192735920?tag=2bqf910c8d2g5b0l4gmrifq1xbvxfdmg
After migration:
https://github.com/TraceMachina/nativelink/pkgs/container/nativelink/193042543?tag=symgcw9plncfbp18vizjhzl8nfknbkgr
It looks like the
config.Labels
section behaves slightly differently between the two.dockerTools
adds the labels to the manifest, visible withdocker manifest inspect someimage
, whilenix2container
adds it to theConfig
section in the output ofdocker image inspect someimage
.AFAIU the behavior of
dockerTools
is actually incorrect as the annotations shouldn't live inconfig
but in a separateannotations
field instead: https://github.com/opencontainers/image-spec/blob/main/manifest.md#image-manifest-property-descriptionsWould it be possible/sensible to add an
annotations
field tobuildImage
and friends?The text was updated successfully, but these errors were encountered: