Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: order of plugins and extraConfig sections in generated tmux.conf #3555

Open
2 tasks done
alex35mil opened this issue Jan 2, 2023 · 8 comments · May be fixed by #6486
Open
2 tasks done

bug: order of plugins and extraConfig sections in generated tmux.conf #3555

alex35mil opened this issue Jan 2, 2023 · 8 comments · May be fixed by #6486
Assignees
@rycee @sumnerevans @berbiche
Labels
bug triage Issues or feature request that have not been triaged yet

Comments

@alex35mil
Copy link

Are you following the right branch?

  • My Nixpkgs and Home Manager versions are in sync

Is there an existing issue for this?

  • I have searched the existing issues

Issue description

I feel that it's not a bug, and I misuse something, b/c nobody ever reported it, but the case should be common. Anyway.

In generated tmux.conf, the plugins section goes before extraConfig. If I configure a status bar in the extraConfig and want to use values from the plugins, it doesn't work since the status bar must be configured before run-shell calls.

Should these sections be swapped in the output?

Maintainer CC

@rycee (mentioning b/c of git blame. couldn't find the maintainers list)

System information

- system: `"aarch64-darwin"`
 - host os: `Darwin 21.6.0, macOS 12.6`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.11.0`
 - channels(Alex): `"home-manager"`
 - channels(root): `"nixpkgs"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixpkgs`
@alex35mil alex35mil added bug triage Issues or feature request that have not been triaged yet labels Jan 2, 2023
@Pegasust
Copy link

What's the status on this issue? Is there anyone working on a fix?

I think adding a configBeforePlugins field makes sense as an escape hatch for me.

@sumnerevans
Copy link
Member

I think that a new config option sounds like a good idea. We need to try and preserve backwards compatibility, and moving the extraConfig location would cause a breaking change.

Pegasust pushed a commit to Pegasust/home-manager that referenced this issue Mar 24, 2023
@htran-opencolo
tmux: configBeforePlugins for nix-community#3555
3c76f5c
@Pegasust Pegasust mentioned this issue Mar 24, 2023
Closed
7 tasks
@stale
Copy link

stale bot commented Jun 23, 2023

Thank you for your contribution! I marked this issue as stale due to inactivity. Please be considerate of people watching this issue and receiving notifications before commenting 'I have this issue too'. We welcome additional information that will help resolve this issue. Please read the relevant sections below before commenting.

If you are the original author of the issue

  • If this is resolved, please consider closing it so that the maintainers know not to focus on this.
  • If this might still be an issue, but you are not interested in promoting its resolution, please consider closing it while encouraging others to take over and reopen an issue if they care enough.
  • If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

If you are not the original author of the issue

  • If you are also experiencing this issue, please add details of your situation to help with the debugging process.
  • If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

Memorandum on closing issues

Don't be afraid to manually close an issue, even if it holds valuable information. Closed issues stay in the system for people to search, read, cross-reference, or even reopen – nothing is lost! Closing obsolete issues is an important way to help maintainers focus their time and effort.

@stale stale bot added the status: stale label Jun 23, 2023
@D3vil0p3r
Copy link
Contributor

Any news?

@stale stale bot removed the status: stale label Jan 14, 2024
@diegodorado
Copy link

This is still needed. Some tmux plugins need to set some configurations before the plugin is loaded (i.e.: tmux-catppuccin)

@tgallacher tgallacher mentioned this issue Mar 28, 2024
Open
2 tasks
@stale Stale
Copy link

stale bot commented Apr 23, 2024

Thank you for your contribution! I marked this issue as stale due to inactivity. Please be considerate of people watching this issue and receiving notifications before commenting 'I have this issue too'. We welcome additional information that will help resolve this issue. Please read the relevant sections below before commenting.

If you are the original author of the issue

  • If this is resolved, please consider closing it so that the maintainers know not to focus on this.
  • If this might still be an issue, but you are not interested in promoting its resolution, please consider closing it while encouraging others to take over and reopen an issue if they care enough.
  • If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

If you are not the original author of the issue

  • If you are also experiencing this issue, please add details of your situation to help with the debugging process.
  • If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

Memorandum on closing issues

Don't be afraid to manually close an issue, even if it holds valuable information. Closed issues stay in the system for people to search, read, cross-reference, or even reopen – nothing is lost! Closing obsolete issues is an important way to help maintainers focus their time and effort.

@stale stale bot added the status: stale label Apr 23, 2024
@podocarp
Copy link
Contributor

podocarp commented Nov 25, 2024 •
edited
Loading

Can I propose to have a extraConfigPre and extraConfigPost section? And then specify a deprecation warning regarding extraConfig.
OR, we can keep extraConfig, and add a extraConfigPost so at least it shows up in the docs that there are these two options, and that its explicit that extraConfig is the *Pre version.

If we can come to some concensus I could make a simple PR for this.

@stale stale bot removed the status: stale label Nov 25, 2024
@mahyarmirrashed
Copy link

Any news on this?

@mahyarmirrashed mahyarmirrashed linked a pull request Feb 18, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rycee rycee

@sumnerevans sumnerevans

@berbiche berbiche

Labels
bug triage Issues or feature request that have not been triaged yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tmux: add extra configuration section before plugin initialization mahyarmirrashed/home-manager
9 participants
@diegodorado @rycee @alex35mil @podocarp @sumnerevans @berbiche @Pegasust @mahyarmirrashed @D3vil0p3r