Interface to get scheme used in request #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented support for 'scheme' in yaws request bridge.
RequestBridge:port() returns the local port of the request. Implemented support for 'port' in yaws request bridge.
|
It is my intention to re-introduce SSL to simple_bridge 2.0, and then will re-add the Let's hear it for 4-year-old pull requests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(copied from previous pull request)
It could be useful to know whether for example https or http (or any other protocol) were used in the request to nitrogen. To know this, there needs to be an interface for this in simple_bridge. This commit contains a proposed interface, and an implementation in yaws. If interested, I could help out in implementing support in the other bridge implementations as well.