Skip to content
This repository has been archived by the owner on Feb 27, 2019. It is now read-only.

Rework presentation method to avoid improper usage of view controllers #148

Open
nickoneill opened this issue Jan 14, 2016 · 0 comments
Open
Milestone

Comments

@nickoneill
Copy link
Owner

Most of the discussion about what's wrong is in #127. Short version:

Here's what I was seeing when I set viewControllerForAlerts: the pscope UI showed up OK, but then clicking on a permission showed the native permissions alert behind the pscope window.

Normally these native alerts are presented on top of the pscope view which works, despite giving a "don't present view controllers on deteached view controllers" warning (because I added the pscope view manually to the current view controller, not through the proper presentation).

I think the correct thing to do here is modify pscope so that it's a view controller presented modally with that setting (the name is on the tip of my tongue...) that allows us to see to the view controller underneath, so it looks like the current implementation. We can customize the presentation with the animated transitioning API if necessary.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants