Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown frame type? #27

Open
Dreathorian opened this issue May 20, 2021 · 6 comments
Open

Unknown frame type? #27

Dreathorian opened this issue May 20, 2021 · 6 comments

Comments

@Dreathorian
Copy link

image

@Dreathorian
Copy link
Author

Dreathorian commented May 20, 2021

Alright figured at least sth out...

Item.cs line 143 should be
case "Class: Stackable Currency":

am having the same issue with map fragments, I guess poe's ctrl+c changed.

map fragments also have a "Class: Map Fragment" added to it that isn't handled here... (gotta check out what the returned int of your Parse_FrameType stands for, hope I do not have to fiddle too much...)

next issue pops up:
No match for: Rarity: Currency, Timeless Eternal Empire Splinter

I'm gonna check that out, bc I'm sick of pricing that stuff for myself ;-)

@Dreathorian
Copy link
Author

Dreathorian commented May 20, 2021

alright I just added some small lines to make it work for the currency tab items that poe.ninja supplies. It seems that oils aren't in the _entryMap, at least it didn't hold the key "Silver Oil", but I couldn't just sift through the 12k entries...

line 122 in item.cs

                case 5:
                    ParseCurrencyData();
                    break;
            }
        }

        private void ParseCurrencyData()
        {
            Key.Name     = Key.TypeLine;
            Key.TypeLine = null;
        }

@Dreathorian
Copy link
Author

Dreathorian commented May 20, 2021

alrighty, looks like we're having an issue here:

scrolls of wisdom and timeless splinters (and maybe others as well) are both stackable currencies but in _entryMap they belong to a different keyframe.

Alright fixed it by checking fragments entryname.contains("Splinter")

Figured Blight and Delve is missing bc they aren't fetched from poe.ninja, I look into it...
edit: scarabs missing as well, gotta check out the poe ninja api i guess...

@Dreathorian
Copy link
Author

ok, fossils, scarabs and oils work now, gotta do resonators next

@Dreathorian
Copy link
Author

k just figured the clipboard parse is off (silly me), but yeah I guess I got into it, I'm gonna figureit out ;-)

@Dreathorian
Copy link
Author

Dreathorian commented May 20, 2021

Alrighty after a nap, I added awakened poe trade compatibility ;-) and fixed the parse error (I think). am trying to get it to work with maps and deliorbs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant