Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated state model class seems to go against the NGXS style guide / recommendations #8

Open
jits opened this issue Apr 8, 2021 · 0 comments

Comments

@jits
Copy link

jits commented Apr 8, 2021

Firstly, thanks to all involved on your wonderful work on NGXS!

The generated code (from this CLI) contains a class for the state model, which seems to go against the NGXS style guide / recommendations (ref: https://www.ngxs.io/recipes/style-guide#avoid-saving-class-based-instances-in-your-state) which suggest that interfaces (and thus plain JS objects) should be used.

Just wondering if this is intentional, or just something that needs tweaking in the CLI? Let me know and I'd be happy to submit a PR to make the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant