Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set correct peerDependency version for @ngxs/store #20

Merged
merged 1 commit into from
Aug 9, 2021
Merged

fix: set correct peerDependency version for @ngxs/store #20

merged 1 commit into from
Aug 9, 2021

Conversation

jase88
Copy link
Contributor

@jase88 jase88 commented Aug 8, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The set peerDependency with @ngxs/store>=5.0.0 does not exist and throws an error

Issue Number: #19

What is the new behavior?

The peerDependency is set to a version that was current at the release of this package (3.6.2)

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@jase88
Copy link
Contributor Author

jase88 commented Aug 8, 2021

@duffleit can you have a look? Thanks 😃

@duffleit duffleit merged commit 5272f8a into ngxs-labs:master Aug 9, 2021
@jase88
Copy link
Contributor Author

jase88 commented Aug 10, 2021

Wow, thank you @duffleit for the quick merge! Any chance for a 0.1.4 npm release?

@seiyria
Copy link

seiyria commented Oct 19, 2022

Just wanted to prod and say this hasn't been formally released yet. Would be great if it could be @duffleit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants