Fix http endpoint scheme #549
Merged
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alice-Lilith
approved these changes
Dec 10, 2024
| @@ -452,6 +452,12 @@ func (td *TunnelDriver) CreateAgentEndpoint(ctx context.Context, name string, sp | |||
| upstreamProto = string(*spec.Upstream.Protocol) | |||
| } | |||
| opts = append(opts, config.WithAppProtocol(upstreamProto)) | |||
|
|
|||
| // TODO: This should probably be inferred from the scheme in the URL | |||
There was a problem hiding this comment.
Did you mean to leave this comment in? If the URL was already parsed using the helper func, then it should already have a scheme, even if the user used one of the shorthand formats.
There was a problem hiding this comment.
This was meant to comment on the ngrok-go SDK not respecting the scheme in the URL that we give it to remind me to fix it upstream. Open to removing it or modifying it for clarity.
There was a problem hiding this comment.
No worries, was just a little confused
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This fixes the agent endpoint getting created as a HTTPS endpoint even though the scheme in the url is HTTP.
How
http, add the scheme opt so that the endpoint is created as a http endpoint instead of https. We may want to consider fixing this in the ngrok SDK going forward.Breaking Changes
No