Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove boilerplate type field from trafficPolicy field #548

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

Alice-Lilith
Copy link
Contributor

Removed the required type field from agentendpoint trafficPolicy field and instead rely on "smarter" xvalidations to ensure that the field is properly configured. The enum still exists internally as a helper so that consumers don't need to check both fields.

@Alice-Lilith Alice-Lilith added the safe to test Enable e2e tests for the PR label Dec 6, 2024
@Alice-Lilith Alice-Lilith requested a review from a team as a code owner December 6, 2024 22:23
@github-actions github-actions bot added area/controller Issues dealing with the controller area/helm-chart Issues dealing with the helm chart labels Dec 6, 2024
@Alice-Lilith Alice-Lilith added this pull request to the merge queue Dec 6, 2024
Merged via the queue into main with commit 7c9314c Dec 6, 2024
8 checks passed
@Alice-Lilith Alice-Lilith deleted the alicewasko/simplify-aep-tp branch December 6, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller Issues dealing with the controller area/helm-chart Issues dealing with the helm chart safe to test Enable e2e tests for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants