Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overflow doesn't add theme to tippy #75

Closed
Jobu08 opened this issue Nov 2, 2021 · 2 comments
Closed

Overflow doesn't add theme to tippy #75

Jobu08 opened this issue Nov 2, 2021 · 2 comments

Comments

@Jobu08
Copy link
Contributor

Jobu08 commented Nov 2, 2021

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[X] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

When onlyTextOverflow is set to true and text changes so it starts overflowing, displayed tippy has wrong theme and probably other properties as well.
It seems that when any input changes all properties are reset to only newly changed ones here

Also another issue found during creating Stackblitz example is that when only text changes and not width of element, tippy does not react to this change. I had to change tippy width via renderer to see the tippy.

Expected behavior

Correctly styled tippy displayed after overflow.

Minimal reproduction of the problem with instructions

https://stackblitz.com/edit/angular-ivy-xflxfu?file=src%2Fapp%2Fapp.component.ts

What is the motivation / use case for changing the behavior?

Environment


Angular version: X.Y.Z


Browser:
- [X] Chrome (desktop) version 95.0.4638.54
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

@NetanelBasal
Copy link
Member

Do you want to create a PR?

@Jobu08
Copy link
Contributor Author

Jobu08 commented Nov 25, 2021

Sure. PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants