Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animations in with popover variant #62

Closed
baleeds opened this issue Jul 14, 2021 · 2 comments
Closed

Animations in with popover variant #62

baleeds opened this issue Jul 14, 2021 · 2 comments

Comments

@baleeds
Copy link

baleeds commented Jul 14, 2021

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

Currently the popover variant has no animation, and adding the animation name to the variant also doesn't result in changes.

Expected behavior

I would like to be able to use animations for popovers.

Minimal reproduction of the problem with instructions

Add the package with the following variation:

    TippyModule.forRoot({
      defaultVariation: 'tooltip',
      variations: {
        popper: {
          ...popperVariation,
          animation: 'fade',
        },
      },

Use the popover variation.

What is the motivation / use case for changing the behavior?

Animation is a critical part of popover UX to indicate to users the origin of the item coming into view.

Environment


Angular version: 11.2.11


Browser:
- [x] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

@NetanelBasal
Copy link
Member

NetanelBasal commented Jul 14, 2021

Do you import the animation style?

@baleeds
Copy link
Author

baleeds commented Jul 14, 2021

@NetanelBasal That was my problem. Thank you for the swift reply.

@baleeds baleeds closed this as completed Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants