Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running tsc after updating to ~8.0.0 produces error TS2307: Cannot find module 'tippy.js' or its corresponding type declarations #143

Closed
KeithGillette opened this issue Jul 19, 2023 · 3 comments

Comments

@KeithGillette
Copy link

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[X] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

Running tsc on a project importing from @ngneat/helipopper@~8.0.0 produces:

node_modules/@ngneat/helipopper/lib/tippy.types.d.ts:1:33 - error TS2307: Cannot find module 'tippy.js' or its corresponding type declarations.

1 import { Instance, Props } from 'tippy.js';

Expected behavior

tsc transpiles without error, as it did in 7.1.1.

Minimal reproduction of the problem with instructions

Run tsc with default skipLibCheck: false on a project importing from @ngneat/helipopper@~8.0.0.

What is the motivation / use case for changing the behavior?

Project should transpile without error.

Environment


Angular version: 16.1.5


Browser:
N/A
 
For Tooling issues:
- Node version: v18.16.1
- Platform:  MacOS 13.4.1

Others:

@shaharkazaz
Copy link
Contributor

shaharkazaz commented Jul 20, 2023

Are you installing your modules in legacy mode? it's defined as peer

@KeithGillette
Copy link
Author

KeithGillette commented Jul 20, 2023

Hi, @shaharkazaz: No, we don't use --legacy-peer-deps or --force on our project. @ngneat/[email protected] transpiled without error.

It looks like we now have to manually add tippy.js as a direct dependency of our project, as we do for Helipopper's previous peer dependency, @ngneat/overview, as documented in the README.md.

@shaharkazaz
Copy link
Contributor

I'll add those 2 into the dependencies and that should resolve the issue and should be automatically installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants