Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lifecycle hooks per variation #137

Closed
frct1 opened this issue Jun 7, 2023 · 2 comments
Closed

Add lifecycle hooks per variation #137

frct1 opened this issue Jun 7, 2023 · 2 comments

Comments

@frct1
Copy link

frct1 commented Jun 7, 2023

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

Currently its working only in case if we define onShow hook at global level but not in a specified variation.
Following source code:

this.globalConfig.onShow?.(instance);
onShow hook is calling only from global settings but i think we can add check is variation contain lifecycleHooks and then call them instead of global one.

Expected behavior

Ability to define lifecyclehooks in directive options or at variation level

What is the motivation / use case for changing the behavior?

Main motivation is to add more freedom of customization for tippy. My case is to hide any other tooltips that already opened to leave only single tooltip visible.

Environment


Angular version: X.Y.Z


Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

@frct1
Copy link
Author

frct1 commented Jun 7, 2023

WDYT ?

@shaharkazaz
Copy link
Contributor

Generally speaking, I don't see why not.
Please share a short design before opening a PR just to make sure we are on the same page 🙂

@ngneat ngneat locked and limited conversation to collaborators Nov 28, 2023
@NetanelBasal NetanelBasal converted this issue into discussion #149 Nov 28, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants