Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Possibility to add additional classes (from code) to the ngneat-modal-content element to allow sizing via Bootstrap col-*, col-[sm|md|lg|xl]-* classes #33

Open
hidegh opened this issue May 13, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@hidegh
Copy link

hidegh commented May 13, 2021

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

Setting styles via Bootstrap classes is not possible.

Expected behavior

Using col col-sm-x classes.

Change needed is minimum:

  1. Add a possibility to set additional classes on the ngneat-dialog-content element
  2. remove the ngneat-dialog-content width: auto style
  3. make possible to avoid forcing height/width styles (especially if the size is not set = or at least when we set it to an empty string)

Minimal reproduction of the problem with instructions


What is the motivation / use case for changing the behavior?

Ease of use, flexibility.

Environment


Angular version: X.Y.Z


Browser:
- [x] Chrome (desktop) version latest
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX  
- Platform:  Windows

Others:

@hidegh hidegh changed the title Possibility to add additional classes (from code) to the ngneat-modal-content element to allow sizing via Bootstrap col-*, col-[sm|md|lg|xl]-* classes [FR] Possibility to add additional classes (from code) to the ngneat-modal-content element to allow sizing via Bootstrap col-*, col-[sm|md|lg|xl]-* classes May 13, 2021
@hidegh
Copy link
Author

hidegh commented May 13, 2021

Would probably add this also as a default:
Let the custom component fill the entire dialog (in case it's fluidly designed)

.ngneat-dialog-content {
  > * {
    display: flex;
    flex: 1 1 auto;
  }
}

@NetanelBasal NetanelBasal added the enhancement New feature or request label Dec 21, 2022
@llaz00
Copy link

llaz00 commented Jul 5, 2024

+1. Would be very useful for Tailwind CSS classes too.

@NetanelBasal
Copy link
Member

You're welcome to submit a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants