Skip to content

Conversation

ciarams87
Copy link
Contributor

@ciarams87 ciarams87 commented Oct 2, 2025

Proposed changes

Problem: As a cluster operator managing traffic for an OpenShift cluster
I want easily deploy NGF as my Gateway API implementation from the Operator Hub
So that it is easier for me to try out and use NGF for my OpenShift environment.

Solution: Add UBI based images and an Operator so we can begin the RedHat Operator Certification process and get NGF into the RedHat Certified OperatorHub

Epic: #3668

Testing:

  • Ran the bundle on an OpenShift cluster, deployed the NGF control plane, and
    • deployed the Gateway using a LoadBalancer service and passed traffic from my local machine to the test backend
    • ran the conformance test suite (v1.2.1) and ensured everything passed (with some caveats)

DRAFT UNTIL #3989, #3980 and #4004 ARE MERGED

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

Added UBI based images and NGINX Gateway Fabric Operator.

@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request helm-chart Relates to helm chart labels Oct 2, 2025
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.83%. Comparing base (6fc41cb) to head (0a0582f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4001   +/-   ##
=======================================
  Coverage   86.82%   86.83%           
=======================================
  Files         128      128           
  Lines       16607    16607           
  Branches       62       62           
=======================================
+ Hits        14419    14420    +1     
+ Misses       2006     2005    -1     
  Partials      182      182           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added the tests Pull requests that update tests label Oct 2, 2025
@ciarams87 ciarams87 force-pushed the feat/openshift-support branch from 4504014 to 28d8e3f Compare October 2, 2025 10:46
@ciarams87 ciarams87 marked this pull request as ready for review October 2, 2025 20:08
@ciarams87 ciarams87 requested review from a team as code owners October 2, 2025 20:08
@ciarams87 ciarams87 force-pushed the feat/openshift-support branch from 8aff6fe to 0a0582f Compare October 2, 2025 20:08
@bjee19
Copy link
Contributor

bjee19 commented Oct 2, 2025

Is this just a merge of the feature branch or were there any other additional changes?

@ciarams87
Copy link
Contributor Author

Is this just a merge of the feature branch or were there any other additional changes?

@bjee19 Just the merge of the feature branch!

@shaun-nx shaun-nx moved this from 🆕 New to 🏗 In Progress in NGINX Gateway Fabric Oct 3, 2025
@shaun-nx shaun-nx moved this from 🏗 In Progress to 👀 In Review in NGINX Gateway Fabric Oct 3, 2025
Copy link
Contributor

@shaun-nx shaun-nx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@salonichf5
Copy link
Contributor

Is this just a merge of the feature branch or were there any other additional changes?

The commits reflect the PRs that were reviewed and merged, if that helps makes review simpler

Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regarding the removing of GatewayStaticAddresses, do we have a system in place of running that test on main/edge when not trying to conform to 1.2.1 for openshift?

PR lgtm, as long as there is some plan moving forwards on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request helm-chart Relates to helm chart release-notes tests Pull requests that update tests
Projects
Status: 👀 In Review
Development

Successfully merging this pull request may close these issues.

5 participants