Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependencies): add Commitizen to project #21

Closed
wants to merge 1 commit into from

Conversation

airaamane
Copy link

re #20: Add Commitizen

@netlify
Copy link

netlify bot commented Mar 12, 2021

Deploy request for ngx-darija rejected.

Rejected with commit 1446b2d

https://docs.netlify.com/configure-builds/environment-variables/#sensitive-variable-policy

@chihab
Copy link
Member

chihab commented Mar 15, 2021

First time I use commitzen on Windows and the output on PowerShell is quite disturbing:

image

@airaamane
Copy link
Author

Interesting, but not unexpected actually. the prepare-commit-message script assumes bash is used, this may be an issue with cz husky hook itself, i will look around if anyone has a solution.
in the meantime, could you try running cz (just cz in cli), see if you still get this duplication please even when bypassing husky hook

@chihab
Copy link
Member

chihab commented Mar 17, 2021

I don't have the issue when running only cz, so as you said the issue is from the husky hook.
You probably saw the discussion here typicode/husky#720

@airaamane airaamane closed this Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants