Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] use project level access tokens #278

Closed
Brilator opened this issue Oct 2, 2024 · 4 comments
Closed

[Feature Request] use project level access tokens #278

Brilator opened this issue Oct 2, 2024 · 4 comments
Assignees
Labels
Type: Feature Request This item is confirmed by the maintainers to be a request for a new feature

Comments

@Brilator
Copy link
Member

Brilator commented Oct 2, 2024

The commit menu offers to add access tokens to circumvent the timeout issue.
We might want to change the tokens to project-based (https://git.nfdi4plants.org/<user>/<arc>/-/settings/access_tokens), instead of user PATs (https://git.nfdi4plants.org/-/user_settings/personal_access_tokens).

That seems securer and easier to track, change, delete on data hub, if not needed any more.

However, that is currently not possible (at least I get a 403 when pasting a project token into ARCitect).

@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Oct 2, 2024
@JonasLukasczyk JonasLukasczyk added Type: Feature Request This item is confirmed by the maintainers to be a request for a new feature and removed Status: Needs Triage This item is up for investigation. labels Oct 2, 2024
@JonasLukasczyk JonasLukasczyk self-assigned this Oct 2, 2024
@JonasLukasczyk
Copy link
Collaborator

I just tested this and I was able to use a project token. Did you create one with all the necessary permissions? I will rename Personal Access Token to Access Token. Should I also open the project access token page instead of the personal access token page when someone clicks on the key icon?

@Brilator
Copy link
Member Author

Brilator commented Oct 4, 2024

Right, I selected API, but did not realize I would also have to select a role, which is not the case for global PATs.

Well, it's a bit tricky. Opening the project access token page will also only work, once the project exists. So the routine would be to push the ARC first without token and add another remote with token, if needed.

@JonasLukasczyk
Copy link
Collaborator

Then I would stick with the current version except the rename. Since project tokens are supported we should just mention this in the documentation.

@JonasLukasczyk
Copy link
Collaborator

fc39a60 renames personal access tokens to the more general access token

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Request This item is confirmed by the maintainers to be a request for a new feature
Projects
Status: Done
Development

No branches or pull requests

2 participants