-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modules: add a panel around diff previews when updating #3246
Conversation
Do you have a screnshot as to what it looks like? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but it would also be nice to have a marker between each group of files too, e.g. set of files per module.
My reasoning is I need to make sure e.g. I look at the combination of a main.nf and meta to make sure I understand what channel modifications I have to make in the pipeline
okay, a bit more difficult, but I will give it a try |
Can just be a straight line across the whole width of screen printed before the question of 'updated X/y/z module'? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files☔ View full report in Codecov by Sentry. |
Yes I think that will do for now (would need to try to test in the wild a few times ). The blue border is nice but I find it's a hit harder to read the name of the module But no strong feeling on the colour |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
fixes #3239