Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
3519aa2
Merge branch 'nf-test-conversion' into dsl2-test-namecollisions
ilight1542 Mar 24, 2025
b2b0394
added error catching for multiple udg treatment in single lib (causes…
ilight1542 Mar 24, 2025
3787542
adjusted default behavior for bam saving to prevent overwriting (with…
ilight1542 Mar 24, 2025
34dd28c
unfinished config for testing for name collisions
ilight1542 Mar 24, 2025
ee05ad1
partial implementation
ilight1542 Mar 24, 2025
8b52233
mild rewrite of DAMAGEMANIPULATION --> GENOTYPING for increased contr…
ilight1542 Mar 25, 2025
e8e812b
update validation, genotyping parameter consistency
ilight1542 Mar 25, 2025
021aea4
removal of partial implementation of name collision config
ilight1542 Mar 25, 2025
07d0a2d
typo in parameter check
ilight1542 Mar 25, 2025
b7ac6ed
fixed erroneous param combo check
ilight1542 Mar 26, 2025
6eb67c4
update genotyping libraries splitting for process names and saving
ilight1542 Mar 26, 2025
71f4510
working RG removal branching for mpileupcaller
ilight1542 Mar 28, 2025
426e4cd
module import for addreadgroups
ilight1542 Mar 28, 2025
199dcd5
adjusted creation of angsd input channel for unmerged libs
ilight1542 Apr 4, 2025
c1b41cf
cleaning of development notes, views
ilight1542 Apr 4, 2025
63ba76f
fixed typo in file output naming
ilight1542 Apr 4, 2025
afd9455
Merge branch 'dev' into dsl2-preserve-damagemanipulation
ilight1542 Apr 4, 2025
59d095f
implemented changes from PR review
ilight1542 Apr 25, 2025
3216e3b
added explanation of behavior when declaring both command line and in…
ilight1542 Apr 25, 2025
d41d06a
Merge branch 'dev' into dsl2-preserve-damagemanipulation
ilight1542 May 16, 2025
6cb1598
update usage
ilight1542 May 16, 2025
b078481
Merge branch 'dev' into dsl2-preserve-damagemanipulation
TCLamnidis Jul 25, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions assets/schema_fasta.json
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@
"genotyping_reference_ploidy": {
"type": "integer",
"meta": ["genotyping_ploidy"],
"default": 2,
"errorMessage": "Organism ploidy for GATK or FreeBayes must be provided as integers."
},
"genotyping_gatk_dbsnp": {
Expand Down
212 changes: 117 additions & 95 deletions conf/modules.config

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions docs/development/manual_tests.md
Original file line number Diff line number Diff line change
Expand Up @@ -991,7 +991,7 @@ nextflow run main.nf -profile test,docker --outdir ./results -w work/ -resume --
## Gatk UG on trimmed reads. Skip bcftools stats.
## Expect: One VCF + .tbi index per sample/reference combination, based on the trimmed bams (this actually shows on the IndelRealigner step and not the UG step). No IR directory. No bcftools_stats file per VCF.
## Checked that the input bam for the UG jobs indeed had trimmed reads. (The full UDG sample has untrimmed bams.)
nextflow run main.nf -profile test,docker --outdir ./results -w work/ -resume --run_genotyping --genotyping_tool 'ug' --genotyping_source 'trimmed' -ansi-log false -dump-channels --skip_bcftools_stats \
nextflow run main.nf -profile test,docker --outdir ./results -w work/ -resume --run_genotyping --genotyping_tool 'ug' --genotyping_source 'trimmed' -ansi-log false -dump-channels --genotyping_skip_bcftools_stats \
--run_trim_bam \
--damage_manipulation_bamutils_trim_double_stranded_none_udg_left 5 \
--damage_manipulation_bamutils_trim_double_stranded_none_udg_right 7 \
Expand Down Expand Up @@ -1030,7 +1030,7 @@ nextflow run main.nf -profile test,docker --outdir ./results -w work/ -resume --
```bash
## Attempt to run Gatk HC on trimmed reads, without activating trimming.
## Expect: FAILURE. Cannot set genotyping source to ;trimmed' without trimming.
nextflow run main.nf -profile test,docker --outdir ./results -w work/ -resume --run_genotyping --genotyping_tool 'hc' --genotyping_source 'trimmed' -ansi-log false -dump-channels --skip_bcftools_stats \
nextflow run main.nf -profile test,docker --outdir ./results -w work/ -resume --run_genotyping --genotyping_tool 'hc' --genotyping_source 'trimmed' -ansi-log false -dump-channels --genotyping_skip_bcftools_stats \
--genotyping_gatk_hc_emitrefconf 'BP_RESOLUTION' \
--genotyping_gatk_hc_out_mode 'EMIT_ALL_ACTIVE_SITES'
```
Expand All @@ -1039,7 +1039,7 @@ nextflow run main.nf -profile test,docker --outdir ./results -w work/ -resume --
## Gatk HC on trimmed reads, with different out mode and emit confidence. Skip bcftools stats.
## Expect: One VCF + .tbi index per sample/reference combination.
## Checked .command.sh for correct args.
nextflow run main.nf -profile test,docker --outdir ./results -w work/ -resume --run_genotyping --genotyping_tool 'hc' --genotyping_source 'trimmed' --run_trim_bam -ansi-log false -dump-channels --skip_bcftools_stats \
nextflow run main.nf -profile test,docker --outdir ./results -w work/ -resume --run_genotyping --genotyping_tool 'hc' --genotyping_source 'trimmed' --run_trim_bam -ansi-log false -dump-channels --genotyping_skip_bcftools_stats \
--genotyping_gatk_hc_emitrefconf 'BP_RESOLUTION' \
--genotyping_gatk_hc_out_mode 'EMIT_ALL_ACTIVE_SITES'
```
Expand All @@ -1063,7 +1063,7 @@ nextflow run main.nf -profile test,docker --outdir ./results -w work/ -resume --
## Freebayes on trimmed reads. Different options, and skip bcftools stats.
## Expect: One VCF + .tbi index per sample/reference combination.
## Checked .command.sh for correct args.
nextflow run main.nf -profile test,docker --outdir ./results -w work/ -resume --run_genotyping --genotyping_tool 'freebayes' --genotyping_source 'trimmed' -ansi-log false -dump-channels --skip_bcftools_stats \
nextflow run main.nf -profile test,docker --outdir ./results -w work/ -resume --run_genotyping --genotyping_tool 'freebayes' --genotyping_source 'trimmed' -ansi-log false -dump-channels --genotyping_skip_bcftools_stats \
--run_trim_bam \
--genotyping_freebayes_skip_coverage 10 \
--genotyping_freebayes_min_alternate_count 2 \
Expand Down
2 changes: 1 addition & 1 deletion docs/usage.md
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ Only the `reference_name`, and `fasta` columns are mandatory, whereas all other
| pmdtools_bed_for_masking | No | Optional path to SNP capture BED file to mask the reference for PMDtools |
| sexdeterrmine_snp_bed | No | Optional path to SNP capture bed files for genetic sex estimation with SexDetERRmine |
| bedtools_feature_file | No | Optional path to feature file for coverage calculation with bedtools |
| genotyping_reference_ploidy | No | Optional integer to specify organism ploidy for genotyping with GATK or FreeBayes |
| genotyping_reference_ploidy | No | Optional integer to specify organism ploidy for genotyping with GATK or FreeBayes (by default set to 2) |
| genotyping_gatk_dbsnp | No | Optional path to SNP annotation file for genotyping with GATK |

Files for `fai`, `dict`, `mapper_index` will be generated by the pipeline for you if not specified.
Expand Down
5 changes: 5 additions & 0 deletions modules.json
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,11 @@
"git_sha": "f0719ae309075ae4a291533883847c3f7c441dad",
"installed_by": ["modules"]
},
"picard/addorreplacereadgroups": {
"branch": "master",
"git_sha": "81880787133db07d9b4c1febd152c090eb8325dc",
"installed_by": ["modules"]
},
"picard/createsequencedictionary": {
"branch": "master",
"git_sha": "20b0918591d4ba20047d7e13e5094bcceba81447",
Expand Down
7 changes: 7 additions & 0 deletions modules/nf-core/picard/addorreplacereadgroups/environment.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

65 changes: 65 additions & 0 deletions modules/nf-core/picard/addorreplacereadgroups/main.nf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

93 changes: 93 additions & 0 deletions modules/nf-core/picard/addorreplacereadgroups/meta.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 13 additions & 0 deletions modules/nf-core/picard/addorreplacereadgroups/tests/bam.config

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 13 additions & 0 deletions modules/nf-core/picard/addorreplacereadgroups/tests/cram.config

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

93 changes: 93 additions & 0 deletions modules/nf-core/picard/addorreplacereadgroups/tests/main.nf.test

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading