Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't support Java 22 #23

Closed
zampino opened this issue Apr 2, 2024 · 2 comments · Fixed by #25 or #28
Closed

Doesn't support Java 22 #23

zampino opened this issue Apr 2, 2024 · 2 comments · Fixed by #25 or #28
Labels
bug Something isn't working

Comments

@zampino
Copy link
Collaborator

zampino commented Apr 2, 2024

As reported in Clerk nextjournal/clerk#642.
@zampino zampino added the bug Something isn't working label Apr 2, 2024
This was referenced Apr 2, 2024
Closed
Closed
@AndreaCrotti
Copy link

Just encountered the same issue

@zampino
Copy link
Collaborator Author

zampino commented Jun 6, 2024

Just encountered the same issue

yes, still a problem, see #24.

@holyjak holyjak mentioned this issue Jul 7, 2024
Closed
@mk mk mentioned this issue Aug 16, 2024
Open
@mk mk mentioned this issue Sep 24, 2024
Merged
mk added a commit that referenced this issue Sep 24, 2024
@mk
Merge pull request #25 from nextjournal/commonmark-java
1690dfe 
This switches the implementation for when using this library from the JVM from markdown-it to commonmark-java. We use generative testing to compare both implementations return the same markup.

This comes with an approximate speedup of 10x and fixes #23.
@mk mk closed this as completed in #25 Sep 24, 2024
@mk mk mentioned this issue Sep 24, 2024
Merged
mk added a commit that referenced this issue Sep 24, 2024
@mk @zampino @borkdude
Use commonmark-java instead of markdown-it via GraalJS (#28)
75f4200 
This switches the implementation for when using this library from the JVM from markdown-it to commonmark-java. We use generative testing to compare both implementations return the same markup.

This comes with an approximate speedup of 10x and fixes #23.
---------

Co-authored-by: Andrea Amantini <[email protected]>
Co-authored-by: Michiel Borkent <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@AndreaCrotti @zampino